Skip to content

launcher: add Steam and Waydroid badges - #2934

Open
sickle-phin wants to merge 1 commit into
AvengeMedia:masterfrom
sickle-phin:feature/new-package-source-badges
Open

launcher: add Steam and Waydroid badges#2934
sickle-phin wants to merge 1 commit into
AvengeMedia:masterfrom
sickle-phin:feature/new-package-source-badges

Conversation

@sickle-phin

@sickle-phin sickle-phin commented Jul 25, 2026

Copy link
Copy Markdown

Description

This PR adds Steam and Waydroid badges to the launcher.
It uses system icons instead of images from the asset folder.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

purian23
purian23 requested changes Aug 2, 2026
View reviewed changes

@purian23 purian23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Couple of items here:

  1. Blank badge visible only checks assetPath.length, so missing theme icons still show an empty slot. Hide when iconPath is empty (prefer iconPath(name, true) like DesktopService/Paths), or ship SVGs like the other sources.

  2. Steam scope only matches steam steam://rungameid/ and loses to earlier flatpak/nix branches. Note native only or broader to Widen/reorder the heuristics.

Nice to have: Waydroid exec variants + a couple screenshots.

@bbedward

bbedward commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

/claude review

@claude

claude Bot commented Aug 20, 2026

Copy link
Copy Markdown

Claude review

No new issues found — the two real problems here are already covered by @purian23's review and still apply.

  • SourceBadge.qml:36 — one-arg Quickshell.iconPath() returns the image-missing fallback for absent theme icons, and visible only checks assetPath.length, so a broken badge shows. Repo convention is iconPath(name, true) (Common/Paths.qml:94, Services/DesktopService.qml) plus gating visible on the resolved path. (already flagged)
  • ControllerUtils.js:134 — steam steam://rungameid/ only matches native Steam, and flatpak/nix branches run first so Flatpak Steam games and NixOS installs never reach it. (already flagged)

Checked: badge source mapping, icon resolution, classifier ordering vs flatpak/snap/appimage/nix, no other consumers of classifyAppSource, no i18n/en.json impact. Model: claude-opus-5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purian23 purian23 purian23 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sickle-phin @bbedward @purian23